impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2347: Reuse metastore client connections in Catalog
Date Wed, 29 Jun 2016 08:12:12 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2347: Reuse metastore client connections in Catalog
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3381/4//COMMIT_MSG
Commit Message:

PS4, Line 9: everytime
> every time
Done


http://gerrit.cloudera.org:8080/#/c/3381/4/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java
File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java:

PS4, Line 57: this.
> Remove here and everywhere else. Not needed...
Done


PS4, Line 85: if (hiveClient_ != null)
> Why is this check needed? Who can set hiveClient_ to null?
Just added to be on safe side incase someone inadvertently  sets to null. Removed.


Line 94:       isInUse_ = true;
> Maybe we should also add a Preconditions.checkState(!isInUse_); here
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message