impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3628: Fix cancellation from shell when security is enabled
Date Wed, 29 Jun 2016 00:21:51 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3628: Fix cancellation from shell when security is enabled

Patch Set 1:

File shell/

PS1, Line 638:     # If the connection fails and the Kerberos has not been enabled,
             :     # check for a valid kerberos ticket and retry the connection
             :     # with kerberos enabled.
             :     if not self.imp_client.connected and not self.use_kerberos:
             :       try:
             :         if call(["klist", "-s"]) == 0:
             :           print_to_stderr(("Kerberos ticket found in the credentials cache,
retrying "
             :                            "the connection with a secure transport."))
             :           self.imp_client.use_kerberos = True
             :           self.imp_client.use_ldap = False
             :           self.imp_client.ldap_password = None
             :           self._connect()
             :       except OSError, e:
             :         pass
> If this code path is being hit then we might want to try this as well on th
Done - by setting the class-wide variables so that next time _new_impala_client() is called,
it will try to use Kerberos instead.
File tests/custom_cluster/

PS1, Line 57: select count(*) from tpch.lineitem a join tpch.lineitem b "
            :                "join tpch.lineitem c
> Any reason not to use a WAIT debug action?

PS1, Line 61: print
> Should go through a logger (here and below), e.g.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: If99085e75708d92a08dbecf0131a2234fedad33a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-HasComments: Yes

View raw message