impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3798: Disable per-split filtering for sequence-based scanners
Date Tue, 28 Jun 2016 21:31:50 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3798: Disable per-split filtering for sequence-based scanners
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

Please complete the parquet testing/investigation but otherwise looks okay as a temporary
workaround. Plan to put it in 5.8.0 branch though, right?

http://gerrit.cloudera.org:8080/#/c/3524/1//COMMIT_MSG
Commit Message:

PS1, Line 15: num_files_queued_
num_unqueued_files_


PS1, Line 19: This bug therefore only shows up when there is >1 scan range per file.
I'm not sure that's true. Seems it can happen with 1 scan range per file as well since even
in that case we won't decrement num_unqueued_files_ properly.


-- 
To view, visit http://gerrit.cloudera.org:8080/3524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4770dd77fd4258c24115d72b572c727b770bd75d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message