impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Clean up Python test import statements
Date Tue, 28 Jun 2016 20:20:02 GMT
Michael Brown has posted comments on this change.

Change subject: Clean up Python test import statements
......................................................................


Patch Set 2:

(2 comments)

Can you run the following tests:

1. debug build / exhaustive tests / HDFS
2. debug build / core tests / S3
3. query generator / leopard smoke test

http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/db_connection.py
File tests/comparison/db_connection.py:

Line 933
Whoops. Is this the correct fix though? How will this work without using a MySQLdb connection?
Why not merge the two MySQLConnection classes' methods?


http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/query.py
File tests/comparison/query.py:

PS2, Line 613:     return LimitClause(self.limit)
This isn't an import change. Was it intentional in this patch?


-- 
To view, visit http://gerrit.cloudera.org:8080/3444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message