impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3729: batch size┘coverage for avro scanner
Date Sat, 25 Jun 2016 00:41:29 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3413/5/testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test
File testdata/workloads/functional-query/queries/DataErrorsTest/avro-errors.test:

Line 5: ---- RESULTS: VERIFY_IS_SUPERSET
We are not differentiating between the result when batchsize=0 and batchsize=1. So if a non
empty result set gets returned when batchsize=0 the test will pass. Is this ok?


-- 
To view, visit http://gerrit.cloudera.org:8080/3413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message