impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3206: Enable codegen for AVRO DECIMAL
Date Fri, 24 Jun 2016 23:19:00 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL
......................................................................


Patch Set 2:

Changes looks good.

Do we have end-to-end test coverage for this? It would be good to confirm that a) we have
tests that scan avro decimal tables and b) those tests actually use codegen (sometimes it
gets disabled if the 
schema doesn't match).

-- 
To view, visit http://gerrit.cloudera.org:8080/3489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message