impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3206: Enable codegen for AVRO DECIMAL
Date Fri, 24 Jun 2016 22:35:32 GMT
Michael Ho has uploaded a new patch set (#2).

Change subject: IMPALA-3206: Enable codegen for AVRO_DECIMAL
......................................................................

IMPALA-3206: Enable codegen for AVRO_DECIMAL

This change adds the missing switch statement in
CodegenReadScalar() for AVRO_DECIMAL so that we will
also codegen if an avro table contains AVRO_DECIMAL.
With this change, the following query improves by 37.5%,
going from 8s to 5s:

select count(distinct l_linenumber), avg(l_extendedprice), max(l_discount), min(l_tax) from
tpch15_avro.lineitem;

This change also un-inlines BitUtil::ByteSwap() as the
third argument 'len' is not compilation constant for
all call sites.

Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hdfs-avro-scanner.cc
M be/src/util/CMakeLists.txt
M be/src/util/bit-util-test.cc
R be/src/util/bit-util.cc
M be/src/util/bit-util.h
M be/src/util/decimal-util.h
7 files changed, 9 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/89/3489/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51adf0c1ba76e055f31ccb0034a0d23ea2afb30e
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message