impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3776: fix 'describe formatted' for Avro tables
Date Thu, 23 Jun 2016 21:04:46 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables

Patch Set 1:


Thanks for the comments. I will abandon this change and push a new version to cdh5-trunk.
File fe/src/main/java/com/cloudera/impala/catalog/

PS1, Line 392:  ArrayList<Column> columns = Lists.newArrayList(getNonClusteringColumns());
             :     for (Column column: colsByPos_.subList(0, numClusteringCols_)) {
             :       columns.add(column);
             :     }
             :     return columns;
> nit: This can be refactored to use getClusteringColumns()
File fe/src/main/java/com/cloudera/impala/service/

PS1, Line 185: // For some table formats (e.g. Avro) the column list in the table can differ
from the
             :     // one returned by the Hive metastore. To handle this we use the column
list from the
             :     // table.
> I think we should confirm this behavior change with Marcel/Alex because thi
Yes, Hive also shows the reconciled version, so prior to this change we actually returned
a different result. However our results still differ in the comments for avro tables. I opened to track that.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: If7137b2ef163368b467898d40718f79911c3cf82
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-HasComments: Yes

View raw message