impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3225: Add script to push from gerrit to ASF
Date Thu, 23 Jun 2016 18:25:01 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3225: Add script to push from gerrit to ASF
......................................................................


Patch Set 1:

FYI, this assumes changes are on a gerrit branch with the same name as the ASF branch, which
likely isn't the case at the moment since most of us are developing on cdh5-trunk and on ASF
the trunk branch is 'master'.

Questions:
Are we going to start working/submitting reviews to 'master'? We currently have a branch in
our internal repo called master which is essentially cdh4-trunk. Alternatively we could map
'cdh5-trunk' to asf 'master', e.g. as parameters to this script, but that is a short term
workaround- we should figure out what will happen to the internal development branch. Having
it differ from upstream isn't ideal.

-- 
To view, visit http://gerrit.cloudera.org:8080/3468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15de939acc4b08a8f01511fffcb6ab1743d09c01
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message