impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Date Thu, 23 Jun 2016 00:33:41 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

PS1, Line 198:   # TODO: There is a query in QueryTest/create-table that references nested
types, which
             :   # forces us to skip the entire test case if old aggs and joins are enabled.
This needs
             :   # to be fixed.
> If that's the case, please remove the TODO and replace it with a justificat
I agree that we don't get any additional coverage by running the DDL test with old aggs and
joins. I'll add a justification.


-- 
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message