impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3729: batch size┘coverage for avro scanner
Date Wed, 22 Jun 2016 22:05:15 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
......................................................................


Patch Set 4:

(3 comments)

In this patch, we are not differentiating between the result when batchsize=0 and batchsize=1.
So if a non empty result set gets returned when batchsize=0 the test will pass. Is this ok?

http://gerrit.cloudera.org:8080/#/c/3413/4//COMMIT_MSG
Commit Message:

PS4, Line 14: of
nit: off


http://gerrit.cloudera.org:8080/#/c/3413/4/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

PS4, Line 12: remove_comments, split_section_lines,
            :     join_section_lines
Can you put each of these on a separate line including remove comments. Also they should be
in alphabetical orders.


http://gerrit.cloudera.org:8080/#/c/3413/4/tests/data_errors/test_data_errors.py
File tests/data_errors/test_data_errors.py:

PS4, Line 18: from tests.common.test_dimensions import create_exec_option_dimension
            : from tests.common.impala_test_suite import ImpalaTestSuite
            : from tests.common.skip import SkipIfS3, SkipIfLocal
These should be in alphabetical order. Also the "import x" should be before "from y import
z" statements.
btw, vim has a nice :sort function that sorts lines alphabetically.


-- 
To view, visit http://gerrit.cloudera.org:8080/3413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message