impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Yu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout
Date Wed, 22 Jun 2016 18:35:54 GMT
Juan Yu has posted comments on this change.

Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout
......................................................................


Patch Set 12:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3343/12/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS12, Line 1494: NULL
> Can't we pass runtime_state() here?
We can, but I don't think we need to check it. even if the query is cancelled, we still want
to send the cancel request to remote node.
And this one has a very short timeout, the rpc won't hang for long time like the one in TransmitData().


http://gerrit.cloudera.org:8080/#/c/3343/12/be/src/service/fragment-exec-state.cc
File be/src/service/fragment-exec-state.cc:

PS12, Line 120: NULL
> Same here. Can't we pass executor_.runtime_state() here?
see L#93, runtime state may not have been set.
and same as CancelRemoteFragment request, this one only has short timeout, it won't hang for
long.


PS12, Line 122: Status(res.status)
> Will this be valid when '!can_retry' is true?
Good catch, I'll fix it.


-- 
To view, visit http://gerrit.cloudera.org:8080/3343
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6723cfe58df6217f4a9cdd12facd320cbc24964
Gerrit-PatchSet: 12
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Alan Choi <alan@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message