impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3729: batch size┘coverage for avro scanner
Date Tue, 21 Jun 2016 21:38:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3413/1//COMMIT_MSG
Commit Message:

PS1, Line 12:  
> nit: is
Done


http://gerrit.cloudera.org:8080/#/c/3413/1/bin/load-data.py
File bin/load-data.py:

PS1, Line 142:     
> inconsistent indentation
agh, yeah, I need to fix my vim setup for python


http://gerrit.cloudera.org:8080/#/c/3413/1/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:

Line 205:   actual_set = set(map(str, actual_results.rows))
> Is this the right way to verify if it's superset? What if actual = [1, 1, 1
Good point, the intention isn't documented. I think using set semantics (number of duplicates
is ignored) makes sense here, but I'll add a comment and a sanity check since it's not at
all obvious what is intended. There may be cases where it makes sense to factor in duplicates
(bag semantics).


http://gerrit.cloudera.org:8080/#/c/3413/1/tests/util/test_file_parser.py
File tests/util/test_file_parser.py:

Line 26:     return query_section_text.rstrip("\n").rstrip(';')
> Would it be better to rstrip("\n;")?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia007e558d92c7e4ce30be90446fdbb1f50a0ebc4
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message