impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3745: parquet invalid data handling
Date Wed, 15 Jun 2016 22:19:08 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3745: parquet invalid data handling
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3387/3/be/src/exec/data-source-scan-node.cc
File be/src/exec/data-source-scan-node.cc:

PS3, Line 172:   
> nit here and others: indentation looks off. don't we usually indent this 4 
Done


http://gerrit.cloudera.org:8080/#/c/3387/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 2888:       if (col_chunk.file_path != filename()) {
> combine these two if-stmts
Done


http://gerrit.cloudera.org:8080/#/c/3387/3/be/src/exec/parquet-common.h
File be/src/exec/parquet-common.h:

PS3, Line 173: Returns the
             :   /// number of bytes read. 
> maybe move this down to the bottom so the return value is documented in one
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id565a2ccb7b82f9f92cc3b07f05642a3a835bece
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message