impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2836: Change permissions for ADD/DROP PARTITION
Date Wed, 15 Jun 2016 20:39:09 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-2836: Change permissions for ADD/DROP PARTITION
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3327/4//COMMIT_MSG
Commit Message:

PS4, Line 15: ALTER(Ownership)
> Why is that the case? Shouldn't it be INSERT on table and ALL permission on
Done


http://gerrit.cloudera.org:8080/#/c/3327/4/fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java
File fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java:

Line 74:    * caller to specify privilege required for executing the alter statement
> "the table"
Done


Line 75:    * 
> remove extra space
Done


PS4, Line 76: @param analyzer
            :    * @param privilege
            :    *          the privilege required for the statement
            :    * @throws AnalysisException
> We don't use java doc (for the most part). Can you plz remove this?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d971f0ab46fed87b0428d344d002a42644b9847
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message