impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3687: Prefer Avro field name during schema reconciliation
Date Wed, 15 Jun 2016 18:14:09 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3331/5/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java
File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java:

PS5, Line 114:  
"from the column definition"


PS5, Line 112: Mismatched name/type -> Prefer Avro column, except:
             :    *   A CHAR/VARCHAR column definition maps to an Avro STRING. The reconciled
column
             :    *   will preserve the CHAR/VARCHAR type but prefer the column name and comment
from
             :    *   the Avro column.
Maybe it will be more clear if you have:
Mismatched type -> Prefer ... except
Mismatched name/comment -> Prefer


PS5, Line 119: AnalysisException
You need to comment when this function throws an AnalysisException.


Line 136:       // as a CHAR/VARCHAR in the reconciled schema.
Comment that the name and comment come from the Avro schema.


http://gerrit.cloudera.org:8080/#/c/3331/5/testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test
File testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test:

PS5, Line 80: INT
Can we add a type mismatch as well? e.g. make this float


-- 
To view, visit http://gerrit.cloudera.org:8080/3331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message