impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3499: Split catalog update
Date Tue, 14 Jun 2016 17:15:55 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3499: Split catalog update
......................................................................


Patch Set 20:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3067/20/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS20, Line 1262: if (len > 100 * 1024 * 1024 /* 100MB */) {
               :         LOG(WARNING) << "Received large catalog update(>100mb):
"
               :                      << item.key << " is "
               :                      << PrettyPrinter::Print(len, TUnit::BYTES);
               :       }
> Sorry missed this, my intention here was to add some debug logging to figur
Makes sense. This shouldn't be logged at WARNING level, though. At most it should be INFO
as long as it doesn't happen very often.


-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 20
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message