impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3711: Only check privilege for databases in getSchemas()
Date Mon, 13 Jun 2016 18:38:08 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3711: Only check privilege for databases in getSchemas()
......................................................................


Patch Set 1:

As we discussed offline, the implementation is quite confusing. We seem to be evaluating the
search patterns in three different places (MetadataOp, Frontend and Catalog), depending on
the catalog object type. Let's try to simplify the code and have consistent ways of getting
catalog objects and checking their privileges. Thanks for clearing our mess :)

-- 
To view, visit http://gerrit.cloudera.org:8080/3371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message