impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3664: S3A test keys do not work fails
Date Mon, 13 Jun 2016 17:20:09 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3664: S3A test_keys_do_not_work fails
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Carry +1.

http://gerrit.cloudera.org:8080/#/c/3358/2/be/src/runtime/hdfs-fs-cache.cc
File be/src/runtime/hdfs-fs-cache.cc:

PS2, Line 88: // Use a new instance of the filesystem object to be sure that it picks up the
            :         // configura
> Still think this could be clearer. The question is, when reading this comme
Ah makes sense. I've changed this to your suggested comment. Thanks.


-- 
To view, visit http://gerrit.cloudera.org:8080/3358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message