impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3664: S3A test keys do not work fails
Date Mon, 13 Jun 2016 17:09:11 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3664: S3A test_keys_do_not_work fails
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3358/2/be/src/runtime/hdfs-fs-cache.cc
File be/src/runtime/hdfs-fs-cache.cc:

PS2, Line 88: // Use a new instance as we want to override the default values for these specific
            :         // settings.
Still think this could be clearer. The question is, when reading this comment, is the causal
link between wanting to "override the default values" and the need to "use a new instance"
clear? Otherwise this comment is missing the 'why'.

Something like "Use a new instance of the filesystem object to be sure that it picks up the
configuration changes we're going to make. Without this call, a cached filesystem object is
used which is unaffected by calls to hdfsBuilderConfSetStr(). This is unexpected behavior
in the HDFS API, but is unlikely to change."


-- 
To view, visit http://gerrit.cloudera.org:8080/3358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message