impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
Date Fri, 10 Jun 2016 20:49:35 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3286/6//COMMIT_MSG
Commit Message:

PS6, Line 9: When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused
by glog's
           : own stack unwinding mechanism, which catches SIGABRT and removes all other handlers
before
           : aborting.
           : 
           : This change bumps the glog version to include a patch, which backports a change
from glog,
           : which only resets the SIGABRT handler, if it is the one installed by glog itself.
nit: can you wrap this, maybe to 72 cols?


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message