impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Supports download of CDH components from S3.
Date Fri, 10 Jun 2016 19:25:19 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3223: Supports download of CDH components from S3.

Patch Set 2:

File bin/

Line 15: # Bootstrapping the native toolchain with prebuilt binaries
> This comment and the script name is getting increasingly inaccurate now tha
Comments updated. Keep the name of the script the same for now.

Line 288: def download_cdh_components(toolchain_root, cdh_components):
> I have SKIP_TOOLCHAIN_BOOTSTRAP set to true in my environment, so I guess i
Updated the script to not download the package at all if the package directory exists. Will
not use the md5sum files anymore.

Line 342: 
> Extra line in comment.
File bin/

> Maybe a one-liner comment?

Line 253:   if [ "$?" == "0" ]; then
> More concisely:
Done. Don't need the if-statement at all as you said below.

Line 255:   else
> Actually, set -e already fails the script if the com

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I16fa79db0005554cc0a116e74775647ba99f8dda
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message