impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3499: Split catalog update
Date Fri, 10 Jun 2016 18:18:11 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3499: Split catalog update
......................................................................


Patch Set 16:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3067/16/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS16, Line 1279: TUpdateCatalogCacheRequest
> I think that is because c++ class works different than Java class. the beha
That's correct. You can confirm by looking at the generated source for TUpdateCatalogCacheRequest:
there is no __isset field because all the fields are required and therefore assumed to have
default values.


-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 16
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message