impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3664: S3A test keys do not work fails
Date Fri, 10 Jun 2016 17:56:02 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3664: S3A test_keys_do_not_work fails
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3358/1//COMMIT_MSG
Commit Message:

PS1, Line 15: This is fixed by forcing the creation of a new instance of the
            : filesystem object.
Ok, so what's going on is: previously the hdfs builder might return an FS that was already
created, so ignored the new configuration options? You might make that clearer here: "fixed
by forcing the FS builder to return a new instance of the filesystem object, which will read
the configuration changes we make".


http://gerrit.cloudera.org:8080/#/c/3358/1/be/src/runtime/hdfs-fs-cache.cc
File be/src/runtime/hdfs-fs-cache.cc:

PS1, Line 88: // Use a new instance as we're setting our own keys and we do not want defaults
to
            :         // be used from the core-site.
            :         hdfsBuilderSetForceNewInstance(hdfs_builder);
What is this a new instance of? The FS object? We do want the defaults to be used, we just
want to make sure that we override them where we want to.


-- 
To view, visit http://gerrit.cloudera.org:8080/3358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message