impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-XXXX: Add per-fragment information to debug webpage
Date Fri, 10 Jun 2016 12:38:45 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-XXXX: Add per-fragment information to debug webpage
......................................................................


Patch Set 2:

(5 comments)

Looks pretty nice. Thanks for doing this. I just have a few minor comments.

http://gerrit.cloudera.org:8080/#/c/3323/2//COMMIT_MSG
Commit Message:

PS2, Line 9: I'm sure there's a JIRA for this, still looking for it).
IMPALA-1474 ?


http://gerrit.cloudera.org:8080/#/c/3323/2/be/src/service/fragment-mgr.cc
File be/src/service/fragment-mgr.cc:

PS2, Line 52: id.c_str()
nit: PrintId(v.first).c_str() ?


http://gerrit.cloudera.org:8080/#/c/3323/2/www/fragments.tmpl
File www/fragments.tmpl:

PS2, Line 2: 2012
2016


PS2, Line 30: {{id}}
Is it better to make to link it to {{coordinator}}:25000/query_fragments?query_id={{query_id}}&fragment_idx=?
for easy navigation.


http://gerrit.cloudera.org:8080/#/c/3323/2/www/query_fragments.tmpl
File www/query_fragments.tmpl:

PS2, Line 2:  2012
2016


-- 
To view, visit http://gerrit.cloudera.org:8080/3323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d995da50c3a119b7aaf04d6f87e60e9e573a5ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message