impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
Date Fri, 10 Jun 2016 00:52:08 GMT
Lars Volker has uploaded a new patch set (#5).

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................

IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's
own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before
aborting.

This change bumps the glog version to include a patch, which backports a change from glog,
which only resets the SIGABRT handler, if it is the one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
---
M bin/impala-config.sh
M tests/custom_cluster/test_breakpad.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/3286/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message