impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3684, IMPALA-3693: Disable core files for breakpad tests
Date Thu, 09 Jun 2016 10:46:57 GMT
Lars Volker has submitted this change and it was merged.

Change subject: IMPALA-3684, IMPALA-3693: Disable core files for breakpad tests
......................................................................


IMPALA-3684, IMPALA-3693: Disable core files for breakpad tests

The breakpad tests were writing core files when triggering minidump
writes. This was actually not needed and interfered with test execution
and artifact collection. Most notably processes would take a long time
to terminate while writing core files (IMPALA-3684). The core files
would also be wrongly collected by Jenkins (IMPALA-3693).

This change adds code to stop test clusters reliably, making
test_breakpad independent from calling setup-impala-cluster.py via
os.system. It also disables core dumps for the duration of the test and
re-enables them afterwards.

Change-Id: If592339632aa662b59be09d911229566d5772321
Reviewed-on: http://gerrit.cloudera.org:8080/3339
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Silvius Rus <srus@cloudera.com>
Tested-by: Lars Volker <lv@cloudera.com>
---
M tests/custom_cluster/test_breakpad.py
1 file changed, 34 insertions(+), 13 deletions(-)

Approvals:
  Michael Brown: Looks good to me, approved
  Lars Volker: Verified
  Silvius Rus: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If592339632aa662b59be09d911229566d5772321
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>

Mime
View raw message