impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filter insert by 10-50%.
Date Wed, 08 Jun 2016 23:01:36 GMT
Dan Hecht has posted comments on this change.

Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%.
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3338/4/be/src/util/bloom-filter.h
File be/src/util/bloom-filter.h:

Line 160:   if (CpuInfo::IsSupported(CpuInfo::AVX2)) {
We should standardize on one way to dispatch based on CPUs.  According to this page: https://gcc.gnu.org/wiki/FunctionMultiVersioning,
GCC also has built in support for this if you define two versions of BucketInsert(), one with
"default" target and one with "avx2" target.  It doesn't sound like it patches the code directly,
though, so still incurs a runtime cost of dispatching (sounds like they are using "jmp *ptr").


Have you looked at that to see which way would be better?


-- 
To view, visit http://gerrit.cloudera.org:8080/3338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message