impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3606: Fix Java NPE when trying to add an existing partition
Date Wed, 08 Jun 2016 17:42:53 GMT
Bikramjeet Vig has uploaded a new patch set (#3).

Change subject: IMPALA-3606: Fix Java NPE when trying to add an existing partition
......................................................................

IMPALA-3606: Fix Java NPE when trying to add an existing partition

A NPE is also encountered when trying to drop a partition which does
not exist.

Currently, catalogd sends a response to impalad that contains a dummy
TCatalogObject of type "TABLE" but contains nulls for all other fields.
This causes a null pointer exception when impalad tries to access those
null fields. The exception never gets exposed to the user as it was
caught and ignored. In this case, the fix is that catalogd responds with
an empty TCatalogUpdateResult that contains no dummy TCatalogObject objects.

No Testing was added since the NPE never gets exposed to the user.

Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206
---
M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
1 file changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/24/3324/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>

Mime
View raw message