impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3687: Use type from avro schema during schema reconcilation.
Date Wed, 08 Jun 2016 16:35:39 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3687: Use type from avro schema during schema reconcilation.
......................................................................


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/3331/2//COMMIT_MSG
Commit Message:

PS2, Line 7: avro
> nit: Avro (capitalization)
Done


PS2, Line 7: reconcilation
> nit:typo
Done


PS2, Line 9: string/char/varchar
> nit:capitalize for consitency.
Done


PS2, Line 9: here is no effect that we change the 
> I think the commit message can be reworded to indicate the issue we are try
> "having different column name for string types in Avro schema and hive col defs can raise
an error"

I think there is no error? which error were you referring to? it is the way which we choose?
the end result is "there is no effect" since we chose column definition?


http://gerrit.cloudera.org:8080/#/c/3331/2/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java
File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java:

PS2, Line 116: 
             : 
             : 
             : 
> Why did you remove this?
because we do not have any logic for treating timestamp differently?


http://gerrit.cloudera.org:8080/#/c/3331/1/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test:

Line 72: CREATE EXTERNAL TABLE alltypesagg_changed_column_name_comment (
> Why in hive?
if it is done in impala then frontend analysis will reconcile that but if in Hive, catalog
will reconcile this. they use the same code though. I am good with either way..


http://gerrit.cloudera.org:8080/#/c/3331/2/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test
File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test:

PS2, Line 71: Avro
> nit: Avro
Done


PS2, Line 71: # IMPALA-3687
> I think avro-schema-resolution.test is a better place for this.
I am fine with anything.. what do you think @Alex?


-- 
To view, visit http://gerrit.cloudera.org:8080/3331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message