impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shirish Gajera (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2033: Netezza compatibility functions quote ident
Date Wed, 08 Jun 2016 04:47:44 GMT
Shirish Gajera has posted comments on this change.

Change subject: IMPALA-2033: Netezza compatibility functions quote_ident
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS2, Line 1952: ABC
> I took another look at these tests. Why do the upper-case strings need to b
I tried this on PostgreSQL and this is the same output I am getting. http://www.lattimore.id.au/2007/01/04/postgresql-dynamic-sql-quote_ident-gotchas/
 this is the design doc given in bug.


PS2, Line 1963: _test
> I think this should be quoted.
Again same comment as earlier this is the same output you will get on PostgreSQL.


http://gerrit.cloudera.org:8080/#/c/3263/2/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

PS2, Line 761: all_lowercase
> Does the string need to be converted to lowercase/ Maybe there's a step mis
I didn't get your question. Can you please elaborate ? I don't why we need to convert it to
lowercase.


-- 
To view, visit http://gerrit.cloudera.org:8080/3263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbac4cd10fe08a6bd4871a03ba3b5f2c20fa8ee1
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Shirish Gajera <gshirishfree@gmail.com>
Gerrit-Reviewer: Shirish Gajera <gshirishfree@gmail.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message