impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3491: Use unique database fixture in test shell commandline.py.
Date Tue, 07 Jun 2016 23:15:10 GMT
David Knupp has uploaded a new patch set (#4).

Change subject: IMPALA-3491: Use unique_database fixture in test_shell_commandline.py.
......................................................................

IMPALA-3491: Use unique_database fixture in test_shell_commandline.py.

Before this change, a single test database was created for the entire suite,
and each test was marked to run serially. With the addition of a test fixture
in tests/conftest.py to create a unique database per each individual method,
it's possible now to run the tests in parallel. (The tables required by
individual tests are created via local test fixtures.)

As such, any methods which had been responsible for setting up the test
database were removed. Pytest markers for running tests serially were also
removed, except in cases where interactions from running concurrency would
affect other tests.

Additional minor changes were made to improve PEP-8 compliance.

The non-serial tests were run in a loop ten times to confirm that there weren't
any unexpected failures.

Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e
---
M tests/shell/test_shell_commandline.py
1 file changed, 100 insertions(+), 91 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/01/3301/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3301
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icdcb04a99c0907fc1ba56baa2497fafb33b0e34e
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message