impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Removal of non-toolchain builds.
Date Tue, 07 Jun 2016 01:47:51 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3223: Removal of non-toolchain builds.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3259/6//COMMIT_MSG
Commit Message:

PS6, Line 13: and
            : setting $SKIP_TOOLCHAIN_BOOTSTRAP to true to avoid the
            : directory from being overwritten by the toolchain boostrapping
            : script.
> Hm I think my main point got lost. I was hoping we could avoid having to ha
We chatted offline, Michael explained that this can be useful if the user is working in an
environment with a bad internet connection. I'm fine with keeping it as long as there's a
reason. Thanks, Michael!


-- 
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message