impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Removal of non-toolchain builds.
Date Tue, 07 Jun 2016 00:09:51 GMT
Hello Casey Ching,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3259

to look at the new patch set (#8).

Change subject: IMPALA-3223: Removal of non-toolchain builds.
......................................................................

IMPALA-3223: Removal of non-toolchain builds.

This change removes the option to build without specifying
the environment variable $IMPALA_TOOLCHAIN. By default, if
it's not set, sourcing impala-config.sh will set it to
$IMPALA_HOME/toolchain. A user can override it by setting
$IMPALA_TOOLCHAIN to his/her own toolchain directory. The
user can also set $SKIP_TOOLCHAIN_BOOTSTRAP to true to
avoid running the toolchain bootstrapping script (e.g. a
particular component in toolchain is at a version not
checked into S3).

$IMPALA_TOOLCHAIN holds some third party binaries which
Impala relies on. They can be compiled from source in the
native toolchain which is public. This commit also removes
build_thirdparty.sh as it's no longer used.

By default, Impala will be built with the compiler in
$IMPALA_TOOLCHAIN but this option can be overridden by
setting environment variable $USE_SYSTEM_GCC to 1.

Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
---
M CMakeLists.txt
M be/CMakeLists.txt
D bin/build_thirdparty.sh
M bin/impala-config.sh
M buildall.sh
D cmake_modules/FindPICLibs.cmake
M cmake_modules/asan_toolchain.cmake
M cmake_modules/toolchain.cmake
8 files changed, 109 insertions(+), 457 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/59/3259/8
-- 
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message