impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) download requirements should download kudu-python and virtualenv
Date Mon, 06 Jun 2016 21:21:41 GMT
Casey Ching has posted comments on this change.

Change subject: download_requirements should download kudu-python and virtualenv
......................................................................


Patch Set 2:

> This is one of the fixes blocking IMPALA-3223: Make git.apache.org
 > code buildable. I'd rather avoid investing too much time into
 > improving this script when it already works ok. Not sure that
 > trying to parse JSON in a shell script is worth it.

Maybe ask Micheal for his opinion. If he's ok with it then it's fine with me. I wouldn't check
this in but maybe that's just me.

-- 
To view, visit http://gerrit.cloudera.org:8080/3217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message