impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Removal of non-toolchain builds.
Date Mon, 06 Jun 2016 20:51:35 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3223: Removal of non-toolchain builds.
......................................................................


Patch Set 7:

Ok so not much has changed since my r6 review.
Overall, my only concern is around the duplication of some variables between the top level
CMakeLists.txt and impala-config.sh. I think there should be 1 place where we set all important
paths so we don't run into issues later.

-- 
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message