impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Removal of non-toolchain builds.
Date Mon, 06 Jun 2016 20:48:31 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3223: Removal of non-toolchain builds.
......................................................................


Patch Set 6:

(9 comments)

I see you updated this while I was reviewing. Here's my feedback on rev 6. I haven't. I'll
pick up the review on rev 7.

http://gerrit.cloudera.org:8080/#/c/3259/6//COMMIT_MSG
Commit Message:

PS6, Line 13: and
            : setting $SKIP_TOOLCHAIN_BOOTSTRAP to true to avoid the
            : directory from being overwritten by the toolchain boostrapping
            : script.
Is there a reason we need to have the user set both IMPALA_TOOLCHAIN and then set SKIP_TOOLCHAIN_BOOTSTRAP?
Could we assume 2 if you've specified the toolchain directory yourself? That would prevent
the user from setting the toolchain directory and having it bootstrapped in a different location,
but that doesn't seem like an interesting case.

Then we'd have 1 less environment variable to require.


http://gerrit.cloudera.org:8080/#/c/3259/6/CMakeLists.txt
File CMakeLists.txt:

PS6, Line 124: 
             : 
this is no longer relevant?


PS6, Line 81: # Newer versions of boost (including the version in toolchain) don't build separate
            : # multithreaded versions (they always are). Make sure to pick those up.
            : set(Boost_USE_MULTITHREADED OFF)
do we need to specify this at all then? It just seems confusing now.


PS6, Line 113: $ENV{BOOST_ROOT}
Why is this defined in impala-config.sh while we set other PACKAGE_ROOT vars above with set_dep_root?
Ideally we can do the same above. If we need to have it defined in impala-config.sh, can you
assert here that this is actually defined, and add a comment.


http://gerrit.cloudera.org:8080/#/c/3259/6/bin/impala-config.sh
File bin/impala-config.sh:

PS6, Line 43: -z
I think we can check this is a directory instead of just a string

"-d"

http://stackoverflow.com/questions/59838/check-if-a-directory-exists-in-a-shell-script


PS6, Line 44: location
directory


PS6, Line 295: thirdparty
a future change will move this to toolchain?


PS6, Line 343: THRIFT_HOME
Do we need THRIFT_HOME here and THRIFT_ROOT set in CMakeLists.txt? Ideally we don't define
a location twice.


PS6, Line 349: BOOST_ROOT
Do we need BOOST_ROOT here and set in CMakeLists.txt?


-- 
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message