impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3682: Don't retry unrecoverable socket creation errors
Date Mon, 06 Jun 2016 20:37:54 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3682: Don't retry unrecoverable socket creation errors
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3317/1/be/src/rpc/thrift-client.cc
File be/src/rpc/thrift-client.cc:

PS1, Line 36: if (!socket_create_status_.ok()) return socket_create_status_;
> Even if not, we should be defensive against the possibility that someone wi
Makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/3317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394be287143eefc79cf22865898b71ca24c41328
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message