impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-2.6.0 5.8.0) preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
Date Mon, 06 Jun 2016 15:53:32 GMT
Michael Brown has posted comments on this change.

Change subject: preview IMPALA-3630: forward end-to-end test arguments to custom cluster tests
......................................................................


Patch Set 5:

(3 comments)

Lars, see patch set 5.

Also, Jenkins has trouble with breakpad tests, so this is still a preview.

http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1403/
http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1404/

http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:

PS4, Line 89: exploration_strategy
> Thanks for the explanation. It's indeed a bit confusing, as I usually add -
It's not clear to me how someone would know to find information on how to call run-tests.py
written in run-all-tests.sh. It seems like we'd be better benefited by some document explaining
ways to run tests, say in a README.md or somesuch. I'd prefer that be a separate Jira issue.
Let me know if this is OK.


Line 160:     if ! ${IMPALA_HOME}/tests/run-tests.py ${COMMON_PYTEST_ARGS} ${EE_TEST_FILES};
then
> single line?
Done


Line 194:     fi
> single line?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message