impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuanhao Luo (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.
Date Mon, 06 Jun 2016 04:59:22 GMT
Yuanhao Luo has uploaded a new patch set (#2).

Change subject: IMPALA-2878: Remove unused function and duplicate codes.
......................................................................

IMPALA-2878: Remove unused function and duplicate codes.

Original impala::Base64Decode() method wouldn't return original string if
there were trailing '\0'. For example, string "a\0" would be encoded into
"YQA=", whild calling original Base64Decode() method, the return value
is "a", which losts the trailing '\0' of original string "a\0". Thinking
that this function isn't used anywhere, this commit just remove it. Besides
this commit remove duplicate codes of function impala::Base64Encode() and
impala::StringFunctions::Base64Encode().

Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
---
M be/src/exprs/string-functions-ir.cc
M be/src/util/url-coding-test.cc
M be/src/util/url-coding.cc
M be/src/util/url-coding.h
4 files changed, 61 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/11/3311/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>

Mime
View raw message