impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.
Date Sat, 04 Jun 2016 03:05:04 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-2878: Remove unused function and duplicate codes.
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

Line 826:   result.CopyFrom(ctx, reinterpret_cast<const uint8_t*>(encoded_str.c_str()),
> Sorry, I don't understand what do you mean by "make both functions wrappers
There are two Base64Functions in Impala. If they cannot both be made wrappers around the sasl
base64 encoder without having a redundant copies, you might need to make a wrapper around
the sasl base64 encoder and have bothe impala base64 encoders call that.

If you absolutely must have a copy, please put it in the one that already has a comment that
says it is not very performant.


-- 
To view, visit http://gerrit.cloudera.org:8080/3244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-HasComments: Yes

Mime
View raw message