impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3632: Add script for runnig cppclean over the BE code.
Date Fri, 03 Jun 2016 17:09:56 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code.
......................................................................


Patch Set 1:

(3 comments)

Michael, I wasn't planning on adding cppclean to the toolchain, but we could do that. The
virtualenv might be more appropriate since it's a python tool. On the other hand, this is
a tool only to be used by devs for cleanup, and not during builds//packaging, so I'm not sure
whether it even makes sense to check it in. What do you think?

http://gerrit.cloudera.org:8080/#/c/3237/1/CMakeLists.txt
File CMakeLists.txt:

Line 361: if (DUMP_INCLUDE_PATHS)
> It would make more sense for this to be a custom target.
I originally tried that but couldn't make it work because the commands I want to run are CMake
commands, at least the one for getting the includes property. So those commands are meaningless
in a make file. Not sure what COMMAND to execute here. Any ideas?


http://gerrit.cloudera.org:8080/#/c/3237/1/bin/cppclean.sh
File bin/cppclean.sh:

Line 2: #
> Copyright header?
Done


Line 30: eval $CMD
> eval isn't necessary here, could just do something like
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cd064344bdf47d77058fb570f034bb324308103
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message