impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
Date Fri, 03 Jun 2016 16:49:46 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 2: Code-Review+2

LGTM, +2 assuming you've run the jenkins job to test the build (PUBLISH=0). Also locally that
you've tested Impala against the new glog build.

After that, you can submit this and run the jenkins job w/ PUBLISH=1, then we can get your
Impala-side change in.

-- 
To view, visit http://gerrit.cloudera.org:8080/3285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message