impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
Date Fri, 03 Jun 2016 16:45:56 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 1:

(1 comment)

Thanks for the review, please see PS2. Another look at the glog change won't hurt, but given
it has already been reviews upstream it should be fine.

http://gerrit.cloudera.org:8080/#/c/3285/1/buildall.sh
File buildall.sh:

PS1, Line 138: GFLAGS_VERSION=2.0 GLOG_VERSION=0.3.2-p2 $SOURCE_DIR/source/glog/build.sh
> Rather than editing this line, I'd leave the existing call to build with p1
Good point, I added it back.


-- 
To view, visit http://gerrit.cloudera.org:8080/3285
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97f528f3190b2f09cd2a135551c618d0e501b7a0
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message