impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuanhao Luo (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2878: Remove unused function and duplicate codes.
Date Fri, 03 Jun 2016 06:04:38 GMT
Yuanhao Luo has posted comments on this change.

Change subject: IMPALA-2878: Remove unused function and duplicate codes.
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

Line 805
> I think you should move this comment to where you do the calculation..
Done


Line 826: }
> Please avoid this CopyFrom if at all possible. Perhaps make both functions 
Done


http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/util/url-coding.cc
File be/src/util/url-coding.cc:

Line 110:   // Base64 encoding turns every 3 bytes into 4 characters. If the length is not
> could you elaborate how do you calculate?
Done


Line 152: void Base64Encode(const string& in, stringstream* out) {
> If this is only used in StringFunctions::Base64Decode, it should only exist
Done


http://gerrit.cloudera.org:8080/#/c/3244/4/be/src/util/url-coding.h
File be/src/util/url-coding.h:

Line 47: void Base64Encode(const std::string& in, std::stringstream* out);
> Please use a C++11-style enum.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Yuanhao Luo <luoyuanhao@software.ict.ac.cn>
Gerrit-HasComments: Yes

Mime
View raw message