impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling
Date Thu, 02 Jun 2016 23:59:38 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/2908/6/be/src/runtime/sorter.cc
File be/src/runtime/sorter.cc:

Line 770:       *pinned_all_blocks = false;
should we unpin fixed_len_blocks_[0] at this point?


PS6, Line 1500: remaining
delete, or reword some other way.


PS6, Line 1504: if (sorted_runs_.size() >= min_runs_for_intermediate_merge) {
Not sure this is worth the complication before we have reservations.  See comment below for
where it seems this introduced a bug.


PS6, Line 1527: three
four...

but as we discussed, it looks like there can be a bug when there are 3 runs remaining -- suppose
CreateMerger is able to pin only 2 of them.  CreateMerger will succeed but need an intermediate
merge, but we don't have an output run.


-- 
To view, visit http://gerrit.cloudera.org:8080/2908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfe55cc13c7f2b54cba1d05ade44cbcf6bb573c0
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message