impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Allow compiler to use SSE3 and SSSE3 instructions.
Date Thu, 02 Jun 2016 23:01:03 GMT
Dan Hecht has posted comments on this change.

Change subject: Allow compiler to use SSE3 and SSSE3 instructions.
......................................................................


Patch Set 2:

> > Aren't these already on by default?  I'm pretty sure impalad ends
 > > up with SSSE3 instructions.  What's the default -march for our
 > > toolchain gcc?
 > 
 > I checked by using an SSE3 Intel Intrisic without adding this
 > compiler option. It caused the build to fail with "target specific
 > option mismatch"

SSE3 shouldn't be enabled but SSSE3 might be.  But it might not be.

However, what's the motivation for this change?  Do you see a tangible benefit?  We could
do it, but there might be some Impala users out there running on AMD Bulldozer (2011) even
though we technically require SSSE3.

-- 
To view, visit http://gerrit.cloudera.org:8080/3291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib045e00b5aa71cc6ef16dbda160bfdc7b765158a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message