impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3521: Impalad should communicate with the statestore after binding to the hs2 and besswax ports
Date Wed, 01 Jun 2016 20:27:35 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-3521: Impalad should communicate with the statestore  after binding
to the hs2 and besswax ports
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3264/1//COMMIT_MSG
Commit Message:

Line 7: mpala-352
> please capitalise:
Done


Line 7: Before Impala Network monitor ports start, should not Communication
      : with statetore
> Please make the title a) more succinct and b) clearer. You don't have to co
Done


Line 13: in which we perform these operations.
> You should say why this needs changing, not just that you did it.
Done


http://gerrit.cloudera.org:8080/#/c/3264/1/be/src/service/impalad-main.cc
File be/src/service/impalad-main.cc:

Line 80: // this blocks until the beeswax and hs2 servers terminate
> Comment should be probably on line 92.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c09dafa5475978424e63bc936c0cdf4940df8d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message