impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3223: Enforces that $IMPALA_TOOLCHAIN is set.
Date Wed, 01 Jun 2016 03:12:46 GMT
Casey Ching has posted comments on this change.

Change subject: IMPALA-3223: Enforces that $IMPALA_TOOLCHAIN is set.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3259/1//COMMIT_MSG
Commit Message:

Line 10: the environment variable $IMPALA_TOOLCHAIN. By default, it
For some reason when I read this I thought the var would be required but there would still
be some way to build without the toolchain. It looks like this change removes support for
non-toolchain builds. Is that right? If so, that would make a better title. Removal of non-toolchain
builds seems more important/direct that stating that a var is now always set.


http://gerrit.cloudera.org:8080/#/c/3259/1/CMakeLists.txt
File CMakeLists.txt:

Line 86: set(Boost_USE_MULTITHREADED OFF)
This line conflicts with line 78. I'm guessing this line is the one you want and the line
above should be removed.


http://gerrit.cloudera.org:8080/#/c/3259/1/bin/impala-config.sh
File bin/impala-config.sh:

Line 63:        "leave it unset."
What do you mean by "leave it unset'? I think this message gets printed if $IMPALA_TOOLCHAIN
is unset, so the message seems strange.

Also if the variable is unset then running with "set -u" will fail. That should be guarded
against (this patch should be updated), see line 19 for a little more info.


-- 
To view, visit http://gerrit.cloudera.org:8080/3259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message