Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E6410200B13 for ; Wed, 1 Jun 2016 01:43:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E4DF0160A46; Tue, 31 May 2016 23:43:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37823160A44 for ; Wed, 1 Jun 2016 01:43:59 +0200 (CEST) Received: (qmail 31847 invoked by uid 500); 31 May 2016 23:43:58 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 31836 invoked by uid 99); 31 May 2016 23:43:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 23:43:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D22BEC1515 for ; Tue, 31 May 2016 23:43:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id WOQKh-Z-PJfN for ; Tue, 31 May 2016 23:43:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 44C375F252 for ; Tue, 31 May 2016 23:43:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u4VNhr4J025681; Tue, 31 May 2016 23:43:53 GMT Message-Id: <201605312343.u4VNhr4J025681@ip-10-146-233-104.ec2.internal> Date: Tue, 31 May 2016 23:43:53 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3181:_Add_noexcept_to_some_functions=0A?= X-Gerrit-Change-Id: I96bd2fec6c14771acae1e700bed958951368ee77 X-Gerrit-ChangeURL: X-Gerrit-Commit: 54bcf53f1754e52f9c513022dc7c43ce7f76dbb7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 archived-at: Tue, 31 May 2016 23:44:00 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-3181: Add noexcept to some functions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3256/1//COMMIT_MSG Commit Message: Line 10: known to not throw exceptions A more precise statement would be "known to not throw exceptions explicitly". In theory, new operator can throw exception but even if it does, we don't know how to handle it in the current code anyway. -- To view, visit http://gerrit.cloudera.org:8080/3256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96bd2fec6c14771acae1e700bed958951368ee77 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes